Skip to content

revert: serve status RPC over goridge net/rpc, keep the new API#134

Merged
rustatian merged 2 commits into
masterfrom
revert/connectrpc
Jul 15, 2026
Merged

revert: serve status RPC over goridge net/rpc, keep the new API#134
rustatian merged 2 commits into
masterfrom
revert/connectrpc

Conversation

@rustatian

Copy link
Copy Markdown
Member

Part of the org-wide Connect-RPC revert: the RPC surface returns to net/rpc over the goridge codec while keeping the new api-go message set and method names. Connect handlers were converted in place, connect-only API tests removed, and api-go/goridge/rpc are pinned to the revert branches (pseudo-versions to be replaced by tags).

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the status RPC transport from Connect-RPC back to net/rpc over the goridge codec, while retaining the newer api-go v2 message types and method names.

Changes:

  • Replaced Connect-RPC handlers with net/rpc-style service methods (Status, Ready) returning errors directly.
  • Updated integration tests to dial net/rpc via goridge and removed Connect-only assertions/tests.
  • Adjusted module dependencies to drop Connect-RPC and pin api-go/goridge/http/jobs/rpc to revert-branch pseudo-versions.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/plugin_test.go Switches status RPC integration tests from Connect client to net/rpc goridge client.
tests/go.mod Removes Connect deps; adds/pins goridge + revert-branch pseudo-versions.
tests/go.sum Updates sums to reflect dependency removals/pins.
rpc.go Replaces Connect handler signatures with net/rpc method signatures and error returns.
rpc_test.go Deletes Connect-specific unit test for Connect error code mapping.
plugin.go Changes plugin RPC exposure from Connect handler/path to returning a net/rpc service instance.
go.mod Removes Connect dependency and pins api-go to revert-branch pseudo-version.
go.sum Updates sums to reflect dependency removals/pins.
go.work.sum Updates workspace sums after dependency graph changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/plugin_test.go
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (5baead8) to head (90465f0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   92.43%   92.30%   -0.13%     
==========================================
  Files           6        6              
  Lines         370      364       -6     
==========================================
- Hits          342      336       -6     
  Misses         16       16              
  Partials       12       12              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rustatian rustatian merged commit 7318430 into master Jul 15, 2026
9 checks passed
@rustatian rustatian deleted the revert/connectrpc branch July 15, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants