revert: serve status RPC over goridge net/rpc, keep the new API#134
Merged
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR reverts the status RPC transport from Connect-RPC back to net/rpc over the goridge codec, while retaining the newer api-go v2 message types and method names.
Changes:
- Replaced Connect-RPC handlers with
net/rpc-style service methods (Status,Ready) returning errors directly. - Updated integration tests to dial
net/rpcvia goridge and removed Connect-only assertions/tests. - Adjusted module dependencies to drop Connect-RPC and pin api-go/goridge/http/jobs/rpc to revert-branch pseudo-versions.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/plugin_test.go | Switches status RPC integration tests from Connect client to net/rpc goridge client. |
| tests/go.mod | Removes Connect deps; adds/pins goridge + revert-branch pseudo-versions. |
| tests/go.sum | Updates sums to reflect dependency removals/pins. |
| rpc.go | Replaces Connect handler signatures with net/rpc method signatures and error returns. |
| rpc_test.go | Deletes Connect-specific unit test for Connect error code mapping. |
| plugin.go | Changes plugin RPC exposure from Connect handler/path to returning a net/rpc service instance. |
| go.mod | Removes Connect dependency and pins api-go to revert-branch pseudo-version. |
| go.sum | Updates sums to reflect dependency removals/pins. |
| go.work.sum | Updates workspace sums after dependency graph changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 92.43% 92.30% -0.13%
==========================================
Files 6 6
Lines 370 364 -6
==========================================
- Hits 342 336 -6
Misses 16 16
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the org-wide Connect-RPC revert: the RPC surface returns to net/rpc over the goridge codec while keeping the new api-go message set and method names. Connect handlers were converted in place, connect-only API tests removed, and api-go/goridge/rpc are pinned to the revert branches (pseudo-versions to be replaced by tags).