Add ignore_case argument to element_should_contain #1034
Conversation
|
Trying to help on #849 |
|
Code looks OK, but PR is missing test. PR are not merged without test backing them up. |
|
Hi @aaltat I just pushed my tests for it. Let me know if I'm doing something improperly. |
|
We have had lately problems with the Travis CI, sometimes the test execution stops. It seems that this PR is also suffering from the same problem. I did restart the two failed runs and lets see how it goes. |
| @@ -0,0 +1,19 @@ | |||
| *** Settings *** | |||
There was a problem hiding this comment.
There already is a existing suite for this keyword, in ./test/acceptance/keywords/content_assertions.robot You have two options:
- Move tests from here to the content_assertions suite
- Move the
Element Should Containkeyword test all in same and new suite. Also change the suite name to describe the whole keyword, not just the new feature.
| Test Teardown Close All Browsers | ||
|
|
||
| *** Variables *** | ||
| ${ISSUE_URL} https://github.com/robotframework/SeleniumLibrary/issues/849 |
There was a problem hiding this comment.
Using links to external resources are not allowed. The acceptance test runner starts small http server. which must be used to serve the required html files. Please take an example from the ./test/acceptance/keywords/content_assertions.robot suite.
The test logic is OK,
|
If you want credit for your work, please add your name and short description what you have done in the https://github.com/robotframework/SeleniumLibrary/blob/master/CHANGES.rst |
|
Closing on favour of #1043. |
No description provided.