Do not store recursive trees anymore in inductive blocks.#21901
Open
ppedrot wants to merge 2 commits intorocq-prover:masterfrom
Open
Do not store recursive trees anymore in inductive blocks.#21901ppedrot wants to merge 2 commits intorocq-prover:masterfrom
ppedrot wants to merge 2 commits intorocq-prover:masterfrom
Conversation
ppedrot
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
ppedrot
added a commit
to ppedrot/coq-elpi
that referenced
this pull request
Apr 8, 2026
Backwards compatible, can be merged already.
ppedrot
added a commit
to ppedrot/coq-elpi
that referenced
this pull request
Apr 8, 2026
Backwards compatible, can be merged already.
yannl35133
reviewed
Apr 8, 2026
| infos.is_general | ||
| || Rtree.is_infinite Declareops.eq_recarg | ||
| graph_def.Declarations.mind_recargs | ||
| || Inductiveops.mis_is_recursive graph_def |
Contributor
There was a problem hiding this comment.
Why is this equivalent, or if not a correct replacement?
Member
Author
There was a problem hiding this comment.
Who cares, this is funind.
Contributor
There was a problem hiding this comment.
I saw you made the same change for elpi.
yannl35133
approved these changes
Apr 8, 2026
Contributor
yannl35133
left a comment
yannl35133
left a comment
There was a problem hiding this comment.
I can accept on behalf of @rocq-prover/kernel-maintainers but real users should be the ones to comment on the changes this PR introduces.
gares
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Apr 9, 2026
Contributor
|
@ppedrot If you stand by and add in a comment the invariant that "a non-trivial recursive tree / automaton implies it must have a loop", I'll merge this. |
This data is now useless as it can be recovered from the compiled automaton.
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
rm-inductive-recarg-from-declarations
branch
from
da06334 to
7e63485
Compare
Member
Author
|
I've added a comment to mis_is_recursive to make clean the intended semantics. |
coqbot-app
bot
removed
the
request: full CI
yannl35133
reviewed
Apr 15, 2026
Comment on lines
+66
to
+69
| (** Check if a [one_inductive_body] is recursive. An inductive is recursive | ||
| either if it has a constructor that mentions it in its normal form type, or | ||
| if it nested. Note that the latter case means that an inductive is | ||
| considered recursive even if the nesting type does not mention its argument. *) |
Contributor
There was a problem hiding this comment.
The normal form type of a constructor always mention its inductive (in the codomain).
Also, mutual inductives trigger the check.
Feel free to adapt this suggestion:
Suggested change
| (** Check if a [one_inductive_body] is recursive. An inductive is recursive | |
| either if it has a constructor that mentions it in its normal form type, or | |
| if it nested. Note that the latter case means that an inductive is | |
| considered recursive even if the nesting type does not mention its argument. *) | |
| (** Check if a [one_inductive_body] is recursive. | |
| An inductive is recursive if it has a constructor argument whose type | |
| (or, for function types, the codomain of which) is either | |
| the inductive itself, another inductive of the same mutual block | |
| or another type nesting over the inductive | |
| (without it needing to mention its argument). | |
| Equivalently, an inductive is recursive if its minimized recursive tree is not trivial. *) |
I found another weird edge case, but this is independent from this PR at this stage:
Inductive P (u : unit) := c.
Inductive T := C (x : P (let x := T in tt)).
T is recursive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This data is now useless as it can be recovered from the compiled automaton.