Skip to content

fix(gymv): preserve NeMo-RL rollout metadata - #1

Merged
rohitrango merged 1 commit into
rohitrango:rohit/gymv-nemorl-integrationfrom
aroshanghias-nvd:gymv-nemorl-token-continuity-review
Aug 25, 2026
Merged

rohitrango merged 1 commit into
rohitrango:rohit/gymv-nemorl-integrationfrom
aroshanghias-nvd:gymv-nemorl-token-continuity-review

Conversation

@aroshanghias-nvd

Copy link
Copy Markdown
Collaborator

This is the minimal compatibility follow-up for NVIDIA-NeMo#2700, based directly on the current head of this branch.

It:

  • preserves training token and logprob metadata across Gym-V multi-turn serialization
  • carries responses_create_params through the verify envelope expected by unchanged NeMo-RL
  • avoids duplicating seed observations in Gym-V output
  • adds focused multi-turn regression coverage

Validation:

  • 240 focused tests passed
  • scoped pre-commit checks passed
  • real two-rollout Gym-V plus NeMo-RL policy/optimizer run completed
  • A/B controls reproduced the metadata-loss failures when either required union-ordering fix was removed

No NeMo-RL source changes are required. Merging this PR updates the head branch used by NVIDIA-NeMo#2700.

Signed-off-by: Ali Roshan Ghias <aroshanghias@nvidia.com>
@rohitrango
rohitrango merged commit dfaa327 into rohitrango:rohit/gymv-nemorl-integration Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants