Skip to content

Conversation

@diegov
Copy link
Contributor

@diegov diegov commented Mar 7, 2023

Description of the change

Add support for Spring 6.x and Spring Boot 3.x.

This introduces 3 new artifacts:

rollbar-jakarta-web: replaces rollbar-web, using the jakarta package instead of javax
rollbar-spring6-webmvc: replaces rollbar-spring-webmvc, using Spring 6 and jakarta packages
rollbar-spring-boot3-webmvc: replaces rollbar-spring-boot-webmvc, using Spring Boot 3.x

While the artifact IDs are different, the package names are not modified, the integration classes are still under the com.rollbar.spring package. So upgrading to Spring Boot 3 only requires a change in dependenciees, not user code.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #120474: Rollbar-java Support for Spring Boot 3.x.

@diegov diegov requested a review from ncapilla March 7, 2023 14:18
@diegov diegov force-pushed the diegoveralli/spring-boot3 branch from 90962cb to 8a12ae6 Compare March 7, 2023 14:18
@diegov diegov marked this pull request as ready for review March 7, 2023 14:20
@diegov diegov removed the request for review from ncapilla March 7, 2023 14:25
@diegov diegov marked this pull request as draft March 7, 2023 14:25
This introduces 3 new artifacts:

rollbar-jakarta-web: replaces rollbar-web, using the `jakarta` package instead of `javax`
rollbar-spring6-webmvc: replaces rollbar-spring-webmvc, using Spring 6 and `jakarta` packages
rollbar-spring-boot3-webmvc: replaces rollbar-spring-boot-webmvc, using Spring Boot 3.x

While the artifact IDs are different, the package names are not modified, the integration classes
are still under the `com.rollbar.spring` package. So upgrading to Spring Boot 3 only requires a
change in dependenciees, not user code.
@diegov diegov force-pushed the diegoveralli/spring-boot3 branch from 8a12ae6 to 4a78df8 Compare March 7, 2023 14:36
@diegov diegov requested a review from ncapilla March 7, 2023 14:49
@diegov diegov marked this pull request as ready for review March 7, 2023 14:49
@jmarronm
Copy link

jmarronm commented Mar 8, 2023

@ncapilla please take a look to this PR asap since we have external commitments with users to deliver this work this week
Thanks!

Copy link

@rob-milesz-rollbar rob-milesz-rollbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ready to go

@diegov diegov merged commit c6ac0f5 into master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Spring Boot 3.x

4 participants