forked from jenssegers/laravel-rollbar
-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for Rollbar v3 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel 6 and 7 requires php 7.2 - 8.0, so exclude all php versions after 8.1
Fixing PHP versions of Actions CI in Laravel 6 and 7.
…tions Bump to rollbar-php v3.1.0 for PHP 8.0 compat
This explicitly checks the previous step before `continue-on-error: true` is applied.
The install step is now working. However, we have a test failure that I did not see locally. I will need to dig into that. |
I have been able to reproduce the error locally.
Now, I just need to dig into the cause. |
cyrusradfar
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR includes the work of @philsturgeon and @tobigumo.
Any more work required to make this library compatible with
rollbar/rollbar
v3 will also be rolled up into this PR.Type of change
Related issues
Checklists
Development
Code review