BC - Updates for Laravel 10 and the MonologHandler

[michaelscola]

Updated the composer.json file to be inline with Laravel 10 - dropped all PHP support except 8.1 and added illuminate/support 10 only

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Maintenance
• New release

[danielmorell]

I think we may want to drop support for rollbar/rollbar v2 as it is not compatible with PHP 8.

[jonnott]

..and you're right it's not possible to support Laravel 9.x and below, as they only support monolog v2 and not v3.

[michaelscola]

I think we may want to drop support for rollbar/rollbar v2 as it is not compatible with PHP 8.

Removed older 2x

[danielmorell]

This is related to #141.

[jonnott]

NB @michaelscola Have you seen Monolog's upgrade guide, where it hints at how you'd possibly support multiple Monolog versions (e.g. 2/3) in terms of LogRecord vs array arguments? https://github.com/Seldaek/monolog/blob/main/UPGRADE.md

[michaelscola]

NB @michaelscola Have you seen Monolog's upgrade guide, where it hints at how you'd possibly support multiple Monolog versions (e.g. 2/3) in terms of LogRecord vs array arguments? https://github.com/Seldaek/monolog/blob/main/UPGRADE.md

I did, but you are going to run into an issue because older PHP versions don't support union types and thus will break our typehinting. So really the only option I see is a BC.

[jonnott]

I did, but you are going to run into an issue because older PHP versions don't support union types and thus will break our typehinting. So really the only option I see is a BC.

Sure .. easiest to just target Monolog 3, PHP 8.1, and Laravel 10 then.

[michaelscola]

I did, but you are going to run into an issue because older PHP versions don't support union types and thus will break our typehinting. So really the only option I see is a BC.

Sure .. easiest to just target Monolog 3, PHP 8.1, and Laravel 10 then.

It does seem like a path of diminishing returns to try and get it working.

[jonnott]

@michaelscola See rollbar/rollbar-php#602

[danielmorell]

We released v4.0.0-rc of the core rollbar/rollbar library today! It supports Monolog 3.

@michaelscola Could you bump rollbar/rollbar to ^4.0. I also think orchestra/testbench should be upgraded to v8.

After that I will make the needed updates to automated test suite, then I think we should be in a position to release a beta version for testing.

[michaelscola]

I will go ahead and get this updated today.

…

On Thu, Feb 23, 2023 at 5:43 PM Daniel Morell ***@***.***> wrote: We released v4.0.0-rc of the core rollbar/rollbar library today! It supports Monolog 3. @michaelscola <https://github.com/michaelscola> Could you bump rollbar/rollbar to ^4.0. I also think orchestra/testbench should be upgraded to v8. After that I will make the needed updates to automated test suite, then I think we should be in a position to release a beta version for testing. — Reply to this email directly, view it on GitHub <#142 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH7S4J2TJYRRQBDUKJWHRCTWY7YZJANCNFSM6AAAAAAU5BR2VE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[michaelscola]

We released v4.0.0-rc of the core rollbar/rollbar library today! It supports Monolog 3.

@michaelscola Could you bump rollbar/rollbar to ^4.0. I also think orchestra/testbench should be upgraded to v8.

After that I will make the needed updates to automated test suite, then I think we should be in a position to release a beta version for testing.

This has been completed

[danielmorell]

This looks great! Thank you @michaelscola.

[danielmorell]

I will work on those CI tests this afternoon.