Skip to content

Added support for the illuminate/support package to also accept version 11 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Added support for the illuminate/support package to also accept version 11 #157

merged 1 commit into from
Feb 13, 2024

Conversation

GertjanRoke
Copy link

@GertjanRoke GertjanRoke commented Feb 13, 2024

With this merge request, it will add support for Laravel 11.
The only change that is needed for supporting Laravel 11 is allowing the Illuminate package to accept version 11.0 or higher.

I made this MR because I was already working with Laravel 11 (dev-master) and wanted to install this package as well, but was running into the issue that it's not supporting version 11.
After bumping the version inside a local installation, I ran all error logging command versions, and they were all added to Rollbar issue console.

Don't know if you wanted to keep that PR template boilerplate, if so please let me know I can add it again :)

Copy link

@zdavis-rollbar zdavis-rollbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for the update. Appreciate it!

@zdavis-rollbar zdavis-rollbar merged commit 69ecc7c into rollbar:master Feb 13, 2024
@GertjanRoke
Copy link
Author

@zdavis-rollbar do you have any idea when this will be tagged?

@GertjanRoke GertjanRoke deleted the laravel-11-support branch February 14, 2024 07:42
@zdavis-rollbar
Copy link

Tagged and released.

@GertjanRoke
Copy link
Author

@zdavis-rollbar maybe a strange question, but I guess the tagging went wrong because you made it like this: V8.0.01. But Packagist didn't pick this up, I guess because it's an incorrect format. It should be something like this V8.0.1 instead.

You can see it here as well, it's not in the list of tags: https://packagist.org/packages/rollbar/rollbar-laravel

@zdavis-rollbar
Copy link

I see packagist wasn't auto updated. I have updated packagist and you should be able to get access to it now. I also renamed the tag to v8.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants