Fixed the access_token config getter function. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I came here to make a bug report about this exact issue - following the instructions I configured |
|
Please release this. |
|
@degecko thanks for submitting this PR. I merged it to |
|
@degecko released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the official documentation, the parameter for the token on the logging config file should be called
access_token. However, without this fix, you need to have bothaccess_tokenandtokenset to the same value, underlogging.channels.rollbar. Otherwise, it will not work.This adds another hotfix to replace the
$key, when its value is"token", with"access_token".P.S. As an alternative, you could also replace the line:
$token = static::config('token');with$token = static::config('access_token');, just so we don't add another if. I'll leave the authors to decide which is best.Later edit: I went ahead and created a new commit to remove the extra if and fix the actual bug. But feel free to use either of the versions.