Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Ensure browserResolve has a default filename #40

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ export default function nodeResolve ( options ) {
if ( !importer ) return null;

return new Promise( ( accept, reject ) => {
resolveId(
importee,
{
var opts = {
basedir: dirname( importer ),
packageFilter ( pkg ) {
if ( options.jsnext ) {
Expand All @@ -54,7 +52,18 @@ export default function nodeResolve ( options ) {
return pkg;
},
extensions: options.extensions
},
};

// NOTE: https://www.npmjs.com/package/browser-resolve running in Node v6+ requires
// opts.filename to **not** be undefined; if we are using browserResolve, ensure that option has
// a default configuration value for 'filename'
if (options.browser) {
opts.filename = __filename;
}

resolveId(
importee,
opts,
( err, resolved ) => {
if ( err ) {
if ( skip === true ) accept( false );
Expand Down