Fix libbsd linking problem with `builtin_llvm=OFF` by stephanlachnit · Pull Request #12154 · root-project/root

stephanlachnit · 2023-01-29T14:23:45Z

Signed-off-by: Stephan Lachnit stephanlachnit@debian.org

This Pull request:

Changes or fixes:

Fix for #12152. Requires #12153.

The idea is the following:

add libbsd option & find_packge module defining LIBBSD::libbsd target
define R__USE_LIBBSD in RConfigure.h if libbsd enabled
adjust strlcpy to include bsd/string.h if R__USE_LIBBSD defined
add LIBBSD::libbsd to the public linking interface of Clib

Unfortunately, this does not work. The reason here is that (for some reason beyond me) rootcling_stage1, libCling.so, bin/root and probably more don't link to Clib as target but instead fetch the target object directly.

Relevant CMake documentation:

Example using rootcling_stage1:

Currently in CMake:

ROOT_EXECUTABLE(rootcling_stage1 src/rootcling_stage1.cxx
                              $<TARGET_OBJECTS:Clib>
                              $<TARGET_OBJECTS:ClingUtils>
                              $<TARGET_OBJECTS:Dictgen>
                              $<TARGET_OBJECTS:Foundation_Stage1>
                              LIBRARIES ${CLING_LIBRARIES} ${CMAKE_DL_LIBS} ${CMAKE_THREAD_LIBS_INIT} ${ROOT_ATOMIC_LIBS}
                              NOINSTALL)

I link against the Clib object library, but ignores any target properties like for example this line:

# alternative for strlcpy on linux, see https://github.com/root-project/root/issues/12152
if(libbsd)
  target_link_libraries(Clib PUBLIC LIBBSD::libbsd)
endif()

I don't see why using the Clib target directly should break anything? It's linked also directly, the only difference is that target properties are ignored which shouldn't be the case.

I added a commit with this approach and it seems to work.

Checklist:

tested changes locally
updated the docs (if necessary)

This PR fixes #12152.

phsft-bot · 2023-01-29T14:23:48Z

Can one of the admins verify this patch?

stephanlachnit · 2023-01-29T16:07:43Z

Works with builtin_llvm=ON & libbsd=ON now

Axel-Naumann · 2023-01-30T13:12:00Z

@phsft-bot build

phsft-bot · 2023-01-30T13:12:07Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-30T14:13:49Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 2 more

phsft-bot · 2023-01-30T15:06:47Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-01-30T14:28:17.499Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/core/base/src/TDirectory.cxx:1292:7: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]

phsft-bot · 2023-02-06T07:45:50Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-07-31T20:02:47Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org>

phsft-bot · 2023-07-31T20:31:06Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

stephanlachnit · 2023-07-31T20:36:13Z

I tested this now in a working ROOT install and it seems to work just fine.

phsft-bot · 2023-07-31T21:24:50Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

github-actions · 2023-07-31T22:09:41Z

Test Results

        8 files         8 suites 1d 18h 40m 37s ⏱️
  2 475 tests   2 467 ✔️ 0 💤 8 ❌
18 752 runs 18 744 ✔️ 0 💤 8 ❌

For more details on these failures, see this check.

Results for commit 8929db8.

phsft-bot · 2023-08-02T10:48:48Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.io.json.roottest_root_io_json_make

stephanlachnit · 2023-08-06T16:12:12Z

When using this in externals projects, this happens:

The link interface of target "ROOT::Core" contains:

  PkgConfig::LIBBSD

but the target was not found.

Should be reasonably easy to fix.

phsft-bot · 2023-08-08T21:16:22Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

stephanlachnit · 2023-08-08T21:16:54Z

Should be reasonably easy to fix.

Fixed but closing since not required anymore with #13420.

phsft-bot · 2023-08-08T21:19:06Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-08-08T21:19:05.964Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

phsft-bot · 2023-08-08T21:19:11Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-08-08T21:19:10.432Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

phsft-bot · 2023-08-08T21:44:59Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2023-08-08T21:44:58.391Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

phsft-bot · 2023-08-08T21:51:38Z

Build failed on mac11/noimt.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-08-08T21:51:37.801Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

phsft-bot · 2023-08-08T21:55:17Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

phsft-bot · 2023-08-08T22:37:44Z

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-08-08T22:37:43.744Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

stephanlachnit force-pushed the p-fix-12152 branch 2 times, most recently from d5ac8db to 6d467eb Compare January 29, 2023 14:59

stephanlachnit mentioned this pull request Jan 29, 2023

Building fails with builtin_llvm=OFF: CommandLine Error: Option 'W' registered more than once! #12156

Closed

1 task

couet assigned bellenot Jan 30, 2023

stephanlachnit force-pushed the p-fix-12152 branch from 05f4fdf to 7175780 Compare February 6, 2023 07:45

stephanlachnit force-pushed the p-fix-12152 branch from 7175780 to f13ccf8 Compare July 31, 2023 20:02

stephanlachnit added 2 commits July 31, 2023 22:29

CMake: fix libbsd linking problem with builtin_llvm=OFF

ccc3a04

Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org>

CMake: link object libraries as targets

8929db8

Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org>

stephanlachnit force-pushed the p-fix-12152 branch from f13ccf8 to 8929db8 Compare July 31, 2023 20:30

stephanlachnit marked this pull request as ready for review July 31, 2023 20:31

stephanlachnit requested review from Axel-Naumann, bellenot and pcanal as code owners July 31, 2023 20:31

stephanlachnit marked this pull request as draft August 2, 2023 13:30

stephanlachnit marked this pull request as ready for review August 2, 2023 15:58

stephanlachnit marked this pull request as draft August 6, 2023 16:11

[cmake] Require libbsd in ROOTConfig if enabled

aac9cea

stephanlachnit closed this Aug 8, 2023

stephanlachnit deleted the p-fix-12152 branch August 8, 2023 21:17

Conversation

stephanlachnit commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This Pull request:

Changes or fixes:

Checklist:

Uh oh!

phsft-bot commented Jan 29, 2023

Uh oh!

stephanlachnit commented Jan 29, 2023

Uh oh!

Axel-Naumann commented Jan 30, 2023

Uh oh!

phsft-bot commented Jan 30, 2023

Uh oh!

phsft-bot commented Jan 30, 2023

Failing tests:

Uh oh!

phsft-bot commented Jan 30, 2023

Warnings:

Uh oh!

phsft-bot commented Feb 6, 2023

Uh oh!

phsft-bot commented Jul 31, 2023

Uh oh!

phsft-bot commented Jul 31, 2023

Uh oh!

stephanlachnit commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Jul 31, 2023

Uh oh!

github-actions bot commented Jul 31, 2023

Test Results

Uh oh!

phsft-bot commented Aug 2, 2023

Failing tests:

Uh oh!

stephanlachnit commented Aug 6, 2023

Uh oh!

phsft-bot commented Aug 8, 2023

Uh oh!

stephanlachnit commented Aug 8, 2023

Uh oh!

phsft-bot commented Aug 8, 2023

Errors:

Uh oh!

phsft-bot commented Aug 8, 2023

Errors:

Uh oh!

phsft-bot commented Aug 8, 2023

Errors:

Uh oh!

phsft-bot commented Aug 8, 2023

Errors:

Uh oh!

phsft-bot commented Aug 8, 2023

Uh oh!

phsft-bot commented Aug 8, 2023

Errors:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stephanlachnit commented Jan 29, 2023 •

edited

Loading

stephanlachnit commented Jul 31, 2023 •

edited

Loading