Skip to content

[interpreter] Fix check-cling with builtin_llvm #13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

[interpreter] Fix check-cling with builtin_llvm #13446

merged 1 commit into from
Aug 14, 2023

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Aug 14, 2023

Forward TARGET_TRIPLE which is used by Cling's lit.site.cfg.in.

@hahnjo
[interpreter] Fix check-cling with builtin_llvm
4ea51ca 
Forward TARGET_TRIPLE which is used by Cling's lit.site.cfg.in.
@hahnjo hahnjo self-assigned this Aug 14, 2023
@hahnjo hahnjo requested a review from bellenot as a code owner August 14, 2023 11:57
@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

This was referenced Aug 14, 2023
Merged
Merged
@phsft-bot
Copy link

Build failed on mac11/noimt.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

vgvassilev
vgvassilev approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Test Results

         9 files           9 suites   1d 20h 44m 41s ⏱️
  2 475 tests   2 466 ✔️ 0 💤 9 ❌
21 262 runs  21 253 ✔️ 0 💤 9 ❌

For more details on these failures, see this check.

Results for commit 4ea51ca.

@hahnjo hahnjo merged commit 09b61b4 into root-project:master Aug 14, 2023
@hahnjo hahnjo deleted the fix-check-cling branch August 14, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

Assignees

@hahnjo hahnjo

Labels
in:Cling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hahnjo @phsft-bot @vgvassilev