[CMake] Support standalone builds of Clang #18460
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Clang was installed standalone (in particular, not in the LLVM tree), use the CLANG_INSTALL_PREFIX variable to indicate where it is. This is the same as 02b0dc1, but only changing the behavior when `CLANG_INSTALL_PREFIX` is set without any other changes. This should be a much less risky change (see also the revert in 6179736).
This was referenced Apr 22, 2025
Merged
|
I disagree with merging any build system related work at this point. |
|
Sure, this can also be done after the branching of 6.36! |
Test Results 17 files 17 suites 3d 22h 2m 36s ⏱️ Results for commit 79840fe. |
|
@hahnjo, what do you think about this for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Clang was installed standalone (in particular, not in the LLVM tree), use the CLANG_INSTALL_PREFIX variable to indicate where it is.
This is the same as 02b0dc1, but only changing the behavior when
CLANG_INSTALL_PREFIXis set without any other changes. This should be a much less risky change (see also the revert in 6179736).Follows up on:
builtin_clang=OFF#18386