Skip to content

Conversation

@maelle
Copy link
Member

@maelle maelle commented Apr 19, 2018

as discussed with @sckott

I will let you update the vignette because I was not too sure about the vignette workflow.

@maelle maelle requested a review from sckott April 19, 2018 05:56
@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   80.32%   80.32%           
=======================================
  Files          11       11           
  Lines         249      249           
=======================================
  Hits          200      200           
  Misses         49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d51cc...2797816. Read the comment docs.

Copy link
Contributor

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! all looks good to me

@sckott sckott merged commit 5f947c7 into ropensci:master Apr 19, 2018
@sckott sckott added this to the v0.5.0 milestone Apr 19, 2018
@sebpardo
Copy link
Contributor

Thanks @maelle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants