Add support for hotspot info into ebirdregioninfo() function

[sebpardo]

Based on @gbabineau 's PR, I noticed it would be easiest to include the /ref/hotspot/info API request into the ebirdregioninfo() function rather than create a standalone function to do so (ebirdhotspotinfo()). The main thing missing from this function is proper error checking and messaging, since it does not used ebird_GET().

@gbabineau , I can give you access to my fork so you can add changes to this branch and PR.

Edit:

To Do list

• update ebirdregioninfo() to include hotspot info
• add proper error checking and messaging (might be easiest to just copy the error messaging code from ebird_GET()
• write updated tests
• update documentation, README, and bump version

[gbabineau]

Sounds good. I will do so. I am on business travel this week working long hours and then heading straight to the beach and will be birding long hours so wont get to it for a week or so. Guy

…

On Thu, Jan 24, 2019, 3:09 PM Sebastian Pardo ***@***.*** wrote: Based on @gbabineau <https://github.com/gbabineau> 's PR, I noticed it would be easiest to include the /ref/hotspot/info API request into the ebirdregioninfo() function rather than create a standalone function to do so (ebirdhotspotinfo()). The main thing missing from this function is proper error checking and messaging, since it does not used ebird_GET(). @gbabineau <https://github.com/gbabineau> , I can give you access to my fork so you can add changes to this branch and PR. ------------------------------ You can view, comment on, or merge this pull request online at: #72 Commit Summary - Add support for hotspot info into ebirdregioninfo function File Changes - *M* R/ebirdregioninfo.R <https://github.com/ropensci/rebird/pull/72/files#diff-0> (35) Patch Links: - https://github.com/ropensci/rebird/pull/72.patch - https://github.com/ropensci/rebird/pull/72.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgwManGRa8PDXxukSAGbrPKjMi11icgZks5vGhLkgaJpZM4aRn2D> .

[sebpardo]

No rush, birding comes first! (I was actually in Belize last week, birding there is great!)

I've sent you the invite so you can edit my fork, make sure you make your commits in the hotspotinfo branch, and once you push onto my fork they should appear automatically in this PR. I've also added a task list in the original post to give us both a rough idea what needs to be done before merging.

Have a great trip!

[sebpardo]

Hi @gbabineau , I've made a number of edits to the function and updated the documentation accordingly. The major difference is that I changed the way in which the json object is turned into a data frame so that the column classes are correct from the beginning, so we don't have to change the classes manually. Please have a look and tell me if you think before I merge this PR.

[gbabineau]

Thanks @sebpardo, this looks good! Sorry I have been busy. I am glad you figured out a way not to keep the column class info. I think the documentation (man pages, vignette) still need to be updated. I am on travel without access to my computer so could not run it but see the tests passed or update the documentation. I can also look at it this weekend when I am home.