Skip to content

Conversation

@mfoos
Copy link
Contributor

@mfoos mfoos commented Apr 8, 2020

Description

Adding a function that hits the "checklist feed on a date" endpoint. I'm only including the function and test files because I'm assuming you'd like to regenerate the doc on your own terms.

Related Issue

This guy #78

Example

ebirdchecklistfeed(loc = "L207391", date = "2020-03-24", max = 10)

@sebpardo
Copy link
Contributor

sebpardo commented Apr 9, 2020

This looks great, thank you! I've added a couple more tests, made the existing ones slightly more robust, and updated the documentation. I'll edit the README and vignettes after merging this PR to avoid any merge conflicts as this branch is a few commits behind master.

@sebpardo sebpardo merged commit a52d937 into ropensci:master Apr 9, 2020
@mfoos
Copy link
Contributor Author

mfoos commented Apr 9, 2020

Great, thanks! I had a bit of a headdesk looking at your correction to my test that was going to start spontaneously failing next march

@mfoos mfoos deleted the add_checklist_feed branch April 9, 2020 13:47
@sebpardo
Copy link
Contributor

sebpardo commented Apr 9, 2020

I figured we'd leave that problem to the package maintainer in 101 years from now :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants