-
Notifications
You must be signed in to change notification settings - Fork 50
rgbif 3.7.0 - review #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgbif 3.7.0 - review #498
Conversation
…ownload-pred_isnull
don't have time to review it, but thanks for asking anyway :) & thx for taking over! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with R, so these are general comments.
The code changes look fine, I think there's just some build/process things that need to be handled.
16.04 is no longer in standard support.
Avoids incorrect order of build resulting in this error: OE> unable to load shared object '/home/runner/work/_temp/Library/stringi/libs/stringi.so': OE> libicui18n.so.66: cannot open shared object file: No such file or directory
Apparently sf requires a special install on ubuntu. |
Hello,
This is a pre-release of a new version of rgbif to push to CRAN.
I have made several changes since the last CRAN version, which are summarized below. I thought these changes justified a version bump from
rgbif 3.6.0
torgbif 3.7.0
.There is only one breaking change listed in DEFUNCT. Otherwise old code should work as expected.
This will be my first CRAN release of rgbif, so I would appreciate a review if possible.
@sckott
@vijaybarve
@MattBlissett
@peterdesmet
thanks!
John Waller
rgbif 3.7.0
There is a new rgbif maintainer: John Waller.
NEW FEATURES
derived_dataset()
: New function to register a cleaned or modified dataset on GBIF for citation. (Derived datasets #467)name_backbone_checklist()
: New function that takes a list, vector, or data.frame of scientific names and asynchronously matches them to the backbone. (name_backbone() ideas #475)pred_isnull()
: New predicate function that includes NULL values from a column in the download. (Add support for is_null predicate in occ_download #489)occ_download.print()
: Now prints out much more information including a DOI and citation. (gbif_citation() #494)DEFUNCT
gbif_citation.gbif()
: it is no longer considered best practice to generate a citation fromocc_search()
orocc_data()
. We recommendocc_download()
orderived_dataset()
instead. (gbif_citation() #494)MINOR IMPROVEMENTS
occ_download_wait()
andocc_download_meta()
: now accept a class character download key directly. The keys does do not need to be class "occ_download". (occ_download_wait() and occ_download_meta() should accept download keys #487)name_backbone()
: now returns new columns "verbatim_name", "verabtim_genus" ect. that the user has supplied. This makes it easier for the user to track what has been matched. The verbose argument also has been un-retired. Ifverbose=TRUE
, more results will be returned in a single data.frame. (name_backbone() ideas #475)gbif_citation()
: will now accept a download key directly.occ_download_get()
: Does not throw an error if the data is already present andoverwrite=FALSE
, it will just give a warning and return the already present dataset. This allows users to runocc_download_get(key) %>% occ_download_import()
multiple times without re-downloading the same file withoverwrite=TRUE
.download_predicate_dsl()
: "publishingOrg" and "occurrenceId" now added as download keys. (add download predicate key for PUBLISHING_ORG #496)key_lkup
now includes GBIF-style uppercase keys as well. Sopred("TAXON_KEY",212)
andpred("taxonKey",212)
will both work.DOCUMENTATION
Wrote new articles highlighting new features and encouraging the use of
occ_download()
overocc_search()
.New articles:
BUG FIXES
occ_download_import()
: fixed bug related to select argument. (occ_download_import with 'select' #479)map_fetch()
: fixed bug related tosp::CRS
(Error in map_fetch related to sp::CRS #497)