Skip to content

rgbif 3.7.0 - review #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Feb 7, 2022
Merged

rgbif 3.7.0 - review #498

merged 54 commits into from
Feb 7, 2022

Conversation

jhnwllr
Copy link
Collaborator

@jhnwllr jhnwllr commented Dec 20, 2021

Hello,

This is a pre-release of a new version of rgbif to push to CRAN.

I have made several changes since the last CRAN version, which are summarized below. I thought these changes justified a version bump from rgbif 3.6.0 to rgbif 3.7.0.

There is only one breaking change listed in DEFUNCT. Otherwise old code should work as expected.

This will be my first CRAN release of rgbif, so I would appreciate a review if possible.

@sckott
@vijaybarve
@MattBlissett
@peterdesmet

thanks!
John Waller

rgbif 3.7.0

There is a new rgbif maintainer: John Waller.

NEW FEATURES

DEFUNCT

  • gbif_citation.gbif() : it is no longer considered best practice to generate a citation from occ_search() or occ_data(). We recommend occ_download() or derived_dataset() instead. (gbif_citation() #494)

MINOR IMPROVEMENTS

  • occ_download_wait() and occ_download_meta() : now accept a class character download key directly. The keys does do not need to be class "occ_download". (occ_download_wait() and occ_download_meta() should accept download keys #487)
  • name_backbone() : now returns new columns "verbatim_name", "verabtim_genus" ect. that the user has supplied. This makes it easier for the user to track what has been matched. The verbose argument also has been un-retired. If verbose=TRUE, more results will be returned in a single data.frame. (name_backbone() ideas #475)
  • gbif_citation() : will now accept a download key directly.
  • occ_download_get() : Does not throw an error if the data is already present and overwrite=FALSE, it will just give a warning and return the already present dataset. This allows users to run occ_download_get(key) %>% occ_download_import() multiple times without re-downloading the same file with overwrite=TRUE.
  • download_predicate_dsl() : "publishingOrg" and "occurrenceId" now added as download keys. (add download predicate key for PUBLISHING_ORG #496) key_lkup now includes GBIF-style uppercase keys as well. So pred("TAXON_KEY",212) and pred("taxonKey",212) will both work.

DOCUMENTATION

Wrote new articles highlighting new features and encouraging the use of occ_download() over occ_search().

New articles:

BUG FIXES

@jhnwllr jhnwllr marked this pull request as draft December 21, 2021 10:11
@sckott
Copy link
Contributor

sckott commented Dec 21, 2021

don't have time to review it, but thanks for asking anyway :) & thx for taking over!

Copy link
Collaborator

@MattBlissett MattBlissett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with R, so these are general comments.

The code changes look fine, I think there's just some build/process things that need to be handled.

@jhnwllr
Copy link
Collaborator Author

jhnwllr commented Feb 4, 2022

Apparently sf requires a special install on ubuntu.
https://github.com/r-spatial/sf/

@jhnwllr
Copy link
Collaborator Author

jhnwllr commented Feb 7, 2022

r-spatial/sf#1899

@jhnwllr jhnwllr marked this pull request as ready for review February 7, 2022 15:26
@jhnwllr jhnwllr merged commit c976496 into master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants