-
Notifications
You must be signed in to change notification settings - Fork 350
expose get_data_type method in loaned interfaces #2351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose get_data_type method in loaned interfaces #2351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2351 +/- ##
==========================================
- Coverage 88.99% 88.96% -0.03%
==========================================
Files 148 148
Lines 16805 16805
Branches 1438 1438
==========================================
- Hits 14955 14951 -4
- Misses 1287 1289 +2
- Partials 563 565 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. should we add a test for the set_command methods with other types than double?
The API behind it is already tested, so mostly not needed. |
(cherry picked from commit 7f92700) # Conflicts: # hardware_interface/include/hardware_interface/loaned_command_interface.hpp # hardware_interface/include/hardware_interface/loaned_state_interface.hpp
Co-authored-by: Sai Kishor Kothakota <[email protected]>
This is needed if the user wants to query in the controller code