Skip to content

Call configure() of base class instead of node #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025

Conversation

christophfroehlich
Copy link
Contributor

This was changed for JTC with a96dd54 but we merged other PRs for JTC re-adding get_node()->configure(). I applied the change again for all tests in the repo.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (496e39d) to head (4162f6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1659   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         127      127           
  Lines       12096    12096           
  Branches     1036     1036           
=======================================
  Hits        10254    10254           
  Misses       1503     1503           
  Partials      339      339           
Flag Coverage Δ
unittests 84.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ive_controller/test/test_diff_drive_controller.cpp 94.29% <100.00%> (ø)
...ollers/test/test_joint_group_effort_controller.cpp 98.43% <100.00%> (ø)
...ontroller/test/test_forward_command_controller.cpp 99.24% <100.00%> (ø)
...est_multi_interface_forward_command_controller.cpp 99.13% <100.00%> (ø)
..._broadcaster/test/test_joint_state_broadcaster.cpp 96.92% <100.00%> (ø)
...ory_controller/test/test_trajectory_controller.cpp 99.78% <100.00%> (ø)
...lers/test/test_joint_group_position_controller.cpp 98.36% <100.00%> (ø)
...cycle_controller/test/test_tricycle_controller.cpp 89.21% <100.00%> (ø)
...lers/test/test_joint_group_velocity_controller.cpp 98.43% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 8c649a3 into master Apr 26, 2025
25 of 26 checks passed
@christophfroehlich christophfroehlich deleted the fix/jtc/tests branch April 26, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants