Skip to content

Fix angular velocity direction of diff_drive_controller odometry #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

Fix angular velocity direction of diff_drive_controller odometry #281

merged 1 commit into from
Jan 5, 2022

Conversation

PaulVerhoeckx
Copy link
Contributor

Fixes #280

bmagyar
bmagyar approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, very nice catch, thanks!
I wonder why no unit test has picked this up...

@bmagyar bmagyar merged commit 9a8be06 into ros-controls:master Jan 5, 2022
@bmagyar
Copy link
Member

bmagyar commented Jan 5, 2022

@Mergifyio backport to galactic

@bmagyar
Copy link
Member

bmagyar commented Jan 5, 2022

@Mergifyio backport to foxy

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2022

backport to galactic

❌ No backport have been created

  • Backport to branch to failed: Branch not found
  • Backport to branch galactic failed: Branch not found

mergify bot pushed a commit that referenced this pull request Jan 5, 2022
@PaulVerhoeckx
Fix angular velocity direction of diff_drive_controller odometry (#281)
bf37a3a 
Co-authored-by: Paul Verhoeckx <[email protected]>
(cherry picked from commit 9a8be06)

# Conflicts:
#	diff_drive_controller/src/odometry.cpp
@mergify mergify bot mentioned this pull request Jan 5, 2022
Closed
@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2022

backport to foxy

✅ Backports have been created

@Timple
Copy link
Contributor

Timple commented Jan 6, 2022

Would it make sense to do a new bloom-release?
Before the next galactic sync picks up this bug, but not the fix?

@PaulVerhoeckx PaulVerhoeckx deleted the fix/diff-drive-controller-odometry branch January 19, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diff_drive_controller's odometry rotates in wrong direction
3 participants
@PaulVerhoeckx @bmagyar @Timple