Skip to content

add lyrical to CI jobs and rcl_bindings.rs#640

Open
ottojo wants to merge 4 commits into
ros2-rust:mainfrom
ottojo:lyrical
Open

add lyrical to CI jobs and rcl_bindings.rs#640
ottojo wants to merge 4 commits into
ros2-rust:mainfrom
ottojo:lyrical

Conversation

@ottojo

@ottojo ottojo commented May 17, 2026

Copy link
Copy Markdown
Contributor

Lyrical is about to be released, the rostooling/setup-ros-docker:ubuntu-resolute-ros-lyrical-ros-base-latest docker image already exists. I successfully ran the ../generate_bindings.py rcl_wrapper.h lyrical . command and ran the subscriber example on lyrical.

@xiaoyang20010608

Copy link
Copy Markdown

Hi, thanks for the work on adding Lyrical support.

While testing this PR, I noticed that it currently fails to compile because rclrs/src/rcl_bindings_generated_lyrical.rs appears to be missing from the changeset.

The PR updates rcl_bindings.rs to include the generated Lyrical bindings file, but the generated file itself does not seem to be committed. As a result, a fresh checkout of the branch fails to build with a missing file error.

Could you please verify whether rcl_bindings_generated_lyrical.rs was accidentally omitted from the PR and push it if necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants