Skip to content

Patch Cargo.lock with newer Zenoh commit#957

Merged
sloretz merged 1 commit intorollingfrom
sloretz__patch_logspam
Apr 7, 2026
Merged

Patch Cargo.lock with newer Zenoh commit#957
sloretz merged 1 commit intorollingfrom
sloretz__patch_logspam

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Apr 6, 2026

Description

Trying patching Cargo.lock to use newer Zenoh version to get eclipse-zenoh/zenoh#2528

Fixes #956

Is this user-facing behavior change?

no

Did you use Generative AI?

no

Additional Information

Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
@sloretz sloretz self-assigned this Apr 6, 2026
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 6, 2026

CI (Zenoh only, build --packages-above-and-dependencies zenoh_cpp_vendor , test --packages-above zenoh_cpp_vendor)

  • Linux Build Status (Infra issue; rebuild: Build Status)
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@cottsay cottsay changed the title Patch Cargo.lock with newew Zenoh commit Patch Cargo.lock with newer Zenoh commit Apr 7, 2026
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 7, 2026

CI isn't finished, but it looks promising and could give better signal on tonight's nightlies. Merging.

@sloretz sloretz merged commit 40e4a04 into rolling Apr 7, 2026
5 of 6 checks passed
@sloretz sloretz deleted the sloretz__patch_logspam branch April 7, 2026 03:39
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 7, 2026

Looks like this did not improve the Windows test situation:

22:00:12 The following tests FAILED:
22:00:12 	 46 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__Arrays (Timeout)
22:00:12 	 47 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__BasicTypes (Timeout)
22:00:12 	 48 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__BoundedPlainSequences (Timeout)
22:00:12 	 49 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__BoundedSequences (Timeout)
22:00:12 	 50 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__Builtins (Timeout)
22:00:12 	 51 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__ComplexNestedKey (Timeout)
22:00:12 	 52 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__Constants (Timeout)
22:00:12 	 53 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__Defaults (Timeout)
22:00:12 	 54 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__Empty (Timeout)
22:00:12 	 55 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__KeyedLong (Timeout)
22:00:12 	 56 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__KeyedString (Timeout)
22:00:12 	 57 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__MultiNested (Timeout)
22:00:12 	 58 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__Nested (Timeout)
22:00:12 	 59 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__NonKeyedWithNestedKey (Timeout)
22:00:12 	 60 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__Strings (Timeout)
22:00:12 	 61 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__UnboundedSequences (Timeout)
22:00:12 	 62 - test_publisher_subscriber_cpp__rmw_zenoh_cpp__WStrings (Timeout)
22:00:12 	 63 - test_subscription_valid_data_cpp__rmw_zenoh_cpp (Timeout)
22:00:12 	 64 - test_nested_types__rmw_zenoh_cpp (Timeout)
22:00:12 	 80 - test_publisher_subscriber__rclpy__rclcpp__rmw_zenoh_cpp (Failed)
22:00:12 	 84 - test_requester_replier__rclcpp__rclpy__rmw_zenoh_cpp (Failed)
22:00:12 	 85 - test_action_client_server__rclcpp__rclpy__rmw_zenoh_cpp (Failed)
22:00:12 	 86 - test_publisher_subscriber__rclcpp__rmw_zenoh_cpp (Failed)
22:00:12 	 87 - test_requester_replier__rclcpp__rmw_zenoh_cpp (Failed)
22:00:12 	 88 - test_action_client_server__rclcpp__rmw_zenoh_cpp (Failed)
22:00:12 	 92 - test_publisher_subscriber_serialized__rmw_zenoh_cpp (Timeout)
22:00:12 Errors while running CTest

May have to revert #935

@JEnoch
Copy link
Copy Markdown
Contributor

JEnoch commented Apr 7, 2026

I believe the Cargo.lock patches didn't work.
See the all the build logs containing references to:
https://github.com/eclipse-zenoh/zenoh.git?rev=f27282e78c6e42e04249349049fa68cfbc941369#f27282e7

I created specific branches and commits in zenoh-c to use zenoh e5db0ce8 which includes eclipse-zenoh/zenoh#2528. And #958 to use those commits.

sloretz added a commit that referenced this pull request Apr 7, 2026
This did not improve the Windows test result situation

This reverts commit 40e4a04.
sloretz added a commit that referenced this pull request Apr 7, 2026
This did not improve the Windows test result situation

This reverts commit 40e4a04.
YuanYuYuan pushed a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Apr 10, 2026
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zenoh 1.8.0 causes tests to hang on Windows

3 participants