Reconnect to all previous networks #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With insights from moby/moby#29265 the behaviour is the same as the one from docker-compose * connect to 1 network (at random) at start * disconnect from that network * reconnect to all the network from the previous configuration
Author
|
I'm gonna close this as your PR has been merged and I proposed my patch directly to containrrr#40 |
Owner
|
Cool. Sorry I couldn't give this any attention sooner. I thought I might get to it over the holidays but no such luck! |
Author
|
No problem, it was holidays afterwards. As long as it is merged somewhere else than my own tiny repo, it will make it available to more people. That's what counts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR make watchtower reload the updated containers with all the previous network it was connected to. (very useful while updating containers launched by docker-compose for example, that are connected to db/backend networks and proxy/frontend networks)
I based my work on your fork because I hoped that you changing the docker client lib to the official would solve my problem automagically. It didn't… But that was already a potential big stepping stone that I was ready to make, and that I didn't have to do thanks to you! 👍