Add a --no-pretty option to reduce repo metadata size #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indentation might be pretty, but it also adds a few percent of compressed size to the metadata. for production use a --no-pretty can now be set that reduces the amount of blanks in the repodata xml.
Member
|
Unless you're not compressing the metadata files, this doesn't really make sense. Also, people do download and look at those files, so I'd rather not make it completely unreadable for just a percentage point or two. |
Contributor
Author
|
@Conan-Kudo I am comparing compressed sizes. The gain would be much bigger in raw. Also, the default does not change. It just adds an option to change it. The files are not completely unreadable. Basically one package is one line in the output instead of multiple lines. Plus it's just a |
Member
|
Keep in mind that this doesn't affect anything that is added to the repodata through |
Conan-Kudo
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indentation might be pretty, but it also adds a few percent of compressed size to the metadata. for production use a --no-pretty can now be set that reduces the amount of blanks in the repodata xml.