Use RPMTAG_SHA1HEADER instead of RPMTAG_HDRID #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building against rpm-5.99.91 failed:
/home/test/createrepo_c/src/parsehdr.c: In function ‘cr_package_from_header’:
/home/test/createrepo_c/src/parsehdr.c:669:71: error: ‘RPMTAG_HDRID’ undeclared (first use in this function); did you mean ‘RPMTAG_CVSID’?
669 | headerGetString(hdr, RPMTAG_HDRID));
| ^~~~~~~~~~~~
| RPMTAG_CVSID
RPM intentionally removed RPMTAG_HDRID tag alias in commit
79ba4a3c41702e46edd5a4ce7e17a1f3361eb0e7 ("Drop irrepairable pkgid and
hdrid tag aliases, rename SOURCEPKGID to go").
This patch fixes building against RPMv6 by using RPMTAG_SHA1HEADER
which RPMTAG_HDRID was aliased to. RPMTAG_SHA1HEADER has existed in
RPM since the year 2001. RPMTAG_HDRID was an alias to
RPMTAG_SHA1HEADER all the time RPMTAG_HDRID existed.
In the features we should look for another digest header RPMv6
packages will use.
dcantrell
approved these changes
Jul 22, 2025
Contributor
|
Note that future packages built against the RPMv6 standard may not have the SHA1HEADER at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building against rpm-5.99.91 failed:
RPM intentionally removed RPMTAG_HDRID tag alias in commit 79ba4a3c41702e46edd5a4ce7e17a1f3361eb0e7 ("Drop irrepairable pkgid and hdrid tag aliases, rename SOURCEPKGID to go").
This patch fixes building against RPMv6 by using RPMTAG_SHA1HEADER which RPMTAG_HDRID was aliased to. RPMTAG_SHA1HEADER has existed in RPM since the year 2001. RPMTAG_HDRID was an alias to RPMTAG_SHA1HEADER all the time RPMTAG_HDRID existed.
In the features we should look for another digest header RPMv6 packages will use.