Skip to content

Migrate cmake to find_package(PYTHON* to find_package(Python3. #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jkroonza wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate cmake to find_package(PYTHON* to find_package(Python3. #461

jkroonza wants to merge 1 commit into from

Conversation

@jkroonza
Copy link
Contributor

@jkroonza jkroonza commented Dec 5, 2025

Also bump minimum cmake version to 3.12.

Closes: #460

@jkroonza
Migrate cmake to find_package(PYTHON* to find_package(Python3.
1723a30 
Also bump minimum cmake version to 3.12.

Closes: rpm-software-management#460
Signed-off-by: Jaco Kroon <[email protected]>
@ppisar
Copy link
Contributor

ppisar commented Dec 5, 2025

The tests fail when building the package :

2: Test command: /builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests/run_unittests.sh "-s" "/builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/tests/python/tests"
2: Working Directory: /builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests
2: Test timeout computed to be: 10000000
2: /builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests/run_unittests.sh: line 1: -m: command not found
1/2 Test #2: test_python ......................***Failed    0.00 sec
/builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests/run_unittests.sh: line 1: -m: command not found

Could you correct it?

@jkroonza
Copy link
Contributor Author

jkroonza commented Dec 5, 2025

The tests fail when building the package :

2: Test command: /builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests/run_unittests.sh "-s" "/builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/tests/python/tests"
2: Working Directory: /builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests
2: Test timeout computed to be: 10000000
2: /builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests/run_unittests.sh: line 1: -m: command not found
1/2 Test #2: test_python ......................***Failed    0.00 sec
/builddir/build/BUILD/createrepo_c-1.2.1-build/createrepo_c-1.2.1/build-py3/tests/python/tests/run_unittests.sh: line 1: -m: command not found

Could you correct it?

Will give it a shot yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cmake minimal version and CMP0148 warnings

2 participants

@jkroonza @ppisar