Fix unload plugins behavior without filelists#2047
Merged
Conversation
jan-kolarik
force-pushed
the
jkolarik/fix-unload-removed-plugins-filelists
branch
2 times, most recently
from
041e9be to
8db6d2e
Compare
Member
Author
|
Sorry for the force pushes, it is now ready for the review. |
kontura
requested changes
Feb 8, 2024
For packages originating outside the System repository, we don't populate the `pkg.files` when running without filelists metadata. Use RPM database as a source instead.
jan-kolarik
force-pushed
the
jkolarik/fix-unload-removed-plugins-filelists
branch
from
8db6d2e to
c158f80
Compare
jan-kolarik
commented
Feb 8, 2024
| # check whether removed plugin file is added at the same time (upgrade of a plugin) | ||
| for pkg in transaction.install_set: | ||
| erased_plugin_files.difference_update(pkg.files) | ||
| erased_plugin_files.difference_update(pkg._header[rpm.RPMTAG_FILENAMES]) |
Member
Author
There was a problem hiding this comment.
I believe that here we are with the rpm transaction completed, so the header should be always present, right?
Contributor
There was a problem hiding this comment.
I think so as well, thanks. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For packages originating outside the System repository, we don't populate the
pkg.fileswhen running without filelists metadata. Use RPM database as a source instead.This fixes the CI failing scenario "Moving plugin between subpackages is not considered removal of plugin" which broke due to changes introduced in rpm-software-management/libdnf#1642.
Related: