spec: If DNF5 obsoletes DNF, do not build dnf-automatic#2129
Merged
jan-kolarik merged 1 commit intorpm-software-management:masterfrom Sep 23, 2024
Merged
Conversation
Fedora CI rpmdeplint test failed for dnf-automic in Fedora 42 because
dnf5-plugin-automatic package obsoletes dnf-automatic package there:
Upgrade problems:
dnf-automatic-4.21.1-1.fc42.noarch would be obsoleted by dnf5-plugin-automatic-5.2.5.0-2.fc41.x86_64 from repo fedora-42-x86_64
This patch fixes it by not building dnf-automatic package if a macro
for obsoleting dnf by dnf5 is set. (Similar to a previous
f519e60 commit.)
ppisar
force-pushed
the
do_no_build_obsolete_dnf_automatic
branch
from
094e23b to
2260693
Compare
jan-kolarik
approved these changes
Sep 23, 2024
Member
jan-kolarik
left a comment
jan-kolarik
left a comment
There was a problem hiding this comment.
Looks good, the 1 failing microdnf test is unrelated.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fedora CI rpmdeplint test failed for dnf-automic in Fedora 42 because dnf5-plugin-automatic package obsoletes dnf-automatic package there:
This patch fixes it by not building dnf-automatic package if a macro for obsoleting dnf by dnf5 is set. (Similar to a previous f519e60 commit.)