I18N: The strings from userconfirm.hpp cannot be translated

[sunwire]

dnf5/include/libdnf5-cli/utils/userconfirm.hpp

Lines 43 to 45 in 708604c

	msg = "Is this ok [Y/n]: ";
	} else {
	msg = "Is this ok [y/N]: ";

The strings cannot be translated even if I use the _() macro.
The cmake --build build --target gettext-potfiles command seems to ignore them.
The same with "n", "N", "y" or "Y"

userconfirm() function is used by dnf5, dnf5daemon-client and copr plugin

[sunwire]

Proposed changes
main...sunwire:dnf5:i18n-yesno

PS.
I don't like the multiple uses of #define but I can't think of any other solution.

$ sudo  ./dnf5 install s-tui
Aktualizowanie i ładowanie repozytoriów:
Załadowano repozytoria.
Pakiet                                                                                  Arch.              Wersja                                                                                  Repozytorium                                        Rozmiar
Instalowanie:
 s-tui                                                                                  noarch             1.1.6-3.fc41                                                                            fedora                                            293.4 KiB
Instalowanie zależności:
 python3-urwid                                                                          noarch             2.6.14-2.fc41                                                                           fedora                                              3.2 MiB
 python3-wcwidth                                                                        noarch             0.2.13-5.fc41                                                                           fedora                                            559.8 KiB

Podsumowanie transakcji:
 Instalowanie:         3 pakietów

Całkowity rozmiar pakietów przychodzących wynosi 1 MiB. Należy pobrać 1 MiB.
Po tej operacji zostanie użyte dodatkowo 4 MiB (zainstaluj 4 MiB, usuń 0 B).
Czy to jest ok [t/N]: t

[ppisar]

Thanks for the report. I haven't looked at the code thoroughly, but I don't like two things on the proposed code: It multiplies the confirmation message and it breaks API and ABI of the public /usr/include/libdnf5-cli/utils/userconfirm.hpp header file. But it's possible that the fix will need changing API.

[sunwire]

I don't like two things on the proposed code

I don't like them either, which is why I didn't make a PR.
The problem is that one common message would have to be shared between different text domains. And I don't like that either.

[geraldosimiao]

Hello. Any changes about this?

[kontura]

Related fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2365336

[ppisar]

Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2259605