Remove .pot Files from the Repository and Always Generate Them #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, dnf5 stores the pot (translation template) file in the dnf5 repository, as well as in the dnf5-l10n repository. The dnf5-l10n repository's pot files are regularly updated by a command from the dnf5 repository. However, the dnf5 repository's pot file is not updated automatically. While recent commits have updated the pot file in the dnf5 repository during the release process, it seems keeping the pot file in the repository isn't necessary. We can generate the pot file using gettext's xgettext command, and we already have a CMake target to generate the pot file. This commit changes the destination of the pot file generated by the xgettext command to the build directory. Removing the pot file from the repository will be done in the next commit.
.pot files are no longer stored in the repository.
.pot files are now generated in the build directory, not in the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dnf5 project synchronizes
.potand.pofiles between the dnf5 repository, the dnf5-l10n repository, and Weblate. The.potfiles are generated using thexgettextcommand.While the Source of Truth for
.pofiles is Weblate, which syncs them to the dnf5-l10n and dnf5 repositories, the status of the.potfiles is less clear. The build process merges.potand.pofiles to generate.gmofiles, but there is an issue where the.potfiles in the dnf5 repository are not automatically updated.PR #1745 attempts to resolve this by copying
.potfiles from the dnf5-l10n repository, but this process only occurs during the release phase. This is suboptimal, as.potfiles can be generated directly from the source code.This PR proposes removing
.potfiles from the dnf5 repository and generating them on-the-fly using thexgettextcommand. The.potfiles will be generated in the build directory, and the build process will reference them accordingly. Additionally, this PR updates several GitHub Actions workflows to reflect these changes (e.g., removing the step that copies.potfiles from dnf5-l10n and adjusting the path to.potfiles in the Weblate sync workflow).Related: #1744