Skip to content

Conversation

@jrohel
Copy link
Contributor

@jrohel jrohel commented Sep 11, 2025

No description provided.

@jrohel jrohel requested a review from a team as a code owner September 11, 2025 09:42
@jrohel jrohel requested review from pkratoch and removed request for a team September 11, 2025 09:42
@@ -0,0 +1,480 @@
GNU LIBRARY GENERAL PUBLIC LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update dnf5.spec to package this file with %license macro in the subpackages which use files license like that? And also correct their License RPM tags?

This was referenced Sep 25, 2025
@Conan-Kudo
Copy link
Member

What stuff do we have that's LGPL-2.0 that hasn't just been updated to LGPL-2.1?

@jrohel
Copy link
Contributor Author

jrohel commented Nov 3, 2025

LGPL-2.0 stuff:

$ grep -R --include='*.[ch]pp' 'LGPL-2.0' .
./include/libdnf5/transaction/offline.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./include/libdnf5/utils/bootc.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./include/libdnf5/utils/format.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./include/libdnf5/utils/to_underlying.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./test/libdnf5/system/test_state.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./test/libdnf5/system/test_state.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./dnf5/include/dnf5/offline.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./dnf5/offline.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./dnf5-plugins/automatic_plugin/config_automatic.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./dnf5-plugins/automatic_plugin/config_automatic.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./dnf5-plugins/automatic_plugin/email_message.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./dnf5-plugins/automatic_plugin/emitters.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/transaction/offline.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/utils/dnf4convert/config_module.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/utils/dnf4convert/config_module.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/utils/dnf4convert/dnf4convert.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/utils/dnf4convert/dnf4convert.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/utils/bootc.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/system/state.cpp:// SPDX-License-Identifier: LGPL-2.0-or-later
./libdnf5/system/state.hpp:// SPDX-License-Identifier: LGPL-2.0-or-later
$ grep -R --include='*.py' 'LGPL-2.0' .
./test/python3/libdnf5/rpm/test_package_query_set_operators.py:# SPDX-License-Identifier: LGPL-2.0-or-later
$ grep -R --include='*.rb' 'LGPL-2.0' .
./test/ruby/libdnf5/rpm/test_package_query_set_operators.rb:# SPDX-License-Identifier: LGPL-2.0-or-later

@Conan-Kudo
Copy link
Member

Those all seem like mistakes. All this code is new, there's no reason to have LGPL-2.0-or-later over LGPL-2.1-or-later.

@ppisar
Copy link
Contributor

ppisar commented Nov 7, 2025

Those all seem like mistakes. All this code is new, there's no reason to have LGPL-2.0-or-later over LGPL-2.1-or-later.

The code was written with "either version 2 of the License" in their license disclaimers. This patch is not going to change the license. It only mirrors what was in the disclaimers to SPDX identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants