Set arch to detected x86_64 microarchitecture if available#2591
Open
lleyton wants to merge 2 commits intorpm-software-management:mainfrom
Open
Set arch to detected x86_64 microarchitecture if available#2591lleyton wants to merge 2 commits intorpm-software-management:mainfrom
lleyton wants to merge 2 commits intorpm-software-management:mainfrom
Conversation
|
Commenting as the x86_64_v3 tester for this, everything worked as expected running this build and I could install and run x86_64_v3 packages and below, but not any above what my CPU could handle. |
Contributor
Author
|
Noticed the copr and manifest plugins were failing with my change. I took a look and it seems like they're not using the basearch, even though it seems like that would be the correct behavior when looking at the dnf4 source:
I updated the plugins to use the basearch. I'm not sure why specifically the 43 test is failing, as I'm not able to reproduce the issue locally. Again, I'm not too familiar with the internals of dnf, so please let me know if I'm missing anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for detecting the current microarchitecture is taken from RPM. See the associated comment in the diff. I have tested it, and it seems to allow installation of packages built against a target
x86_64_v*, when the system supports it. Additionally, it seems to prioritize packages that have the same microarch. Everything else seems to work, but please let me know if I'm missing anything, as I'm not too familiar with the internals of dnf5.Closes #1468.