Set POOL_FLAG_ADDFILEPROVIDESFILTERED only when not loading filelists#1675
Merged
m-blaha merged 1 commit intorpm-software-management:dnf-4-masterfrom Oct 4, 2024
Merged
Conversation
It is set in `dnf_sack_load_repo` which means its done for each repo, this is not needed, it would be sufficient to set the flag only once. However there is a ready access to whether filelists are loaded and the call `pool_set_flag` is very cheap. Any alternatives I could see would probably require extending the API which seems unnecessary.
m-blaha
approved these changes
Oct 4, 2024
Member
m-blaha
left a comment
m-blaha
left a comment
There was a problem hiding this comment.
According to my tests, the performance drop is gone. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is set in
dnf_sack_load_repowhich means its done for each repo, this is not needed, it would be sufficient to set the flag only once. However there is a ready access to whether filelists are loaded and the callpool_set_flagis very cheap.Any alternatives I could see would probably require extending the API which seems unnecessary.
For #1674