build: Increase CMake minimal version to 3.5.0 #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 4.0.0 removed a support for CMake < 3.5, causing a configure
error:
CMake Error at CMakeLists.txt:7 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.
Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.
Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
This patch moves CMakeList.txt to the earliest supported version,
3.5.0. It also ports the script to CMP0005 policy which cannot be
disabled anymore. It also moves GNUInstallDirs inclusion after
project() as it requires it for probing a library path.
New CMake deprecation warnigs will be resolved later.
Resolves rpm-software-management#1699
kontura
approved these changes
Mar 3, 2025
Contributor
|
The failing tests are not related. |
kontura
merged commit 099600c
into
rpm-software-management:dnf-4-master
7 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 4.0.0 removed a support for CMake < 3.5, causing a configure error:
CMake Error at CMakeLists.txt:7 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.
This patch moves CMakeList.txt to the earliest supported version, 3.5.0. It also ports the script to CMP0005 policy which cannot be disabled anymore.
New CMake deprecation warnigs will be resolved later.
Resolves #1699