Fix compilation error with musl #1737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With musl, FNM_EXTMATCH is not defined Resolves compilation errors in musl-based systems Signed-off-by: Wang Mingyu <[email protected]>
The basename() function requires the libgen.h header when compiling with musl-libc, otherwise it complains. Also, musl's basename requires char* instead of const char* argument. Signed-off-by: Wang Mingyu <[email protected]>
mfocko
reviewed
Nov 20, 2025
| #include <vector> | ||
|
|
||
| #if !defined(FNM_EXTMATCH) | ||
| #define FNM_EXTMATCH 0 |
Contributor
There was a problem hiding this comment.
If I understand the context correctly, defining it as 0 disables the extended patterns here:
Lines 971 to 973 in 1cfb16f
Would that not cause issues? It's the only place where the macro is being used and from my understanding it would search for the files with patterns in the string verbatim, i.e., ignoring them altogether, but still including them in the filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FNM_EXTMATCH compilation with musl
Fix basename compilation with musl