Describe all problems even when there are protected removals#1743
Merged
evan-goode merged 2 commits intorpm-software-management:dnf-4-masterfrom Feb 4, 2026
Merged
Conversation
Previously, if a transaction involved removal (or dependency break) of a protected package, only the protected package problem would be described by `describeProblemRules`. Information about excluded or versionlocked packages would be missing. For: RHEL-115194
The error message now distinguishes removal of a protected package from breaking dependencies of protected packages.
3f986ec to
aa32b53
Compare
m-blaha
approved these changes
Feb 4, 2026
Member
m-blaha
left a comment
There was a problem hiding this comment.
There definitely is space for enhancement of solver error messages. But this patch is move in right direction.
Member
Author
|
Agreed. Packit cannot test this itself, but tests as passing locally with rpm-software-management/ci-dnf-stack#1822, merging. |
f701c48
into
rpm-software-management:dnf-4-master
5 of 8 checks passed
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a transaction involved removal (or dependency break) of a protected package, only the protected package problem would be described by
describeProblemRules. Information about excluded or versionlocked packages would be missing.Setup:
Current output:
Output with this patch:
which is perhaps too verbose and not ideal, but at least the user gets the message that the necessary package (
systemd-258.3-2.fc43.x86_64) was filtered by exclude.This PR includes commits from #1740 because the ci-dnf-stack PR will depend on rpm-software-management/ci-dnf-stack#1810.
For: RHEL-115194