-
Notifications
You must be signed in to change notification settings - Fork 251
shadow_utils: make shadow --root work by fake permissive mode #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
shadow_utils: make shadow --root work by fake permissive mode #1313
Conversation
|
While the use of |
|
This does not work for me. When I change it from host, then it is remounted. And it is read only, so I cannot change it from chroot neither. |
|
Yes, Mock's selinux plugin has some hacks related to SELinux too, and we do recursive bind-mounts later: mock/mock/py/mockbuild/mounts.py Lines 228 to 231 in db64d46
The point of this hack is to prepare the |
| self._selinux_workaround_applied = True | ||
|
|
||
| def _execute_command(self, command, can_fail=False): | ||
| self._selinux_workaround() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the fix from shadow-maint/shadow#1258 gets released, we no longer need the _selinux_workaround().
| # Tracking upstream bug https://github.com/shadow-maint/shadow/issues/897 | ||
| if self.root.config['use_host_shadow_utils']: | ||
| do_with_status(command + ['--prefix', self.root.make_chroot_path()], raiseExc=not can_fail) | ||
| do_with_status(command + ['--root', self.root.make_chroot_path()], raiseExc=not can_fail) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... but we'll have to continue using --prefix for older buildhosts (not targets, because we use shadow utils from host).
Fixes: #1285