Skip to content

Conversation

@JAICHANGPARK
Copy link
Contributor

@JAICHANGPARK JAICHANGPARK commented Oct 12, 2025

Updated the Korean translation to match the latest version of the README.

  • add : Migration to 3.0.0
  • add: Classic classes

Thanks!

Summary by CodeRabbit

  • Documentation
    • Overhauled Korean README to align with Dart 3 and Freezed 3.0 migration guidance.
    • Updated examples to use sealed classes, const constructors, and updated fromJson/fromJson patterns.
    • Reworked sections, headings, table of contents, and navigation for clearer migration flow.
    • Clarified pattern matching, unions, serialization, deep copies, and const usage with expanded examples.
    • General linguistic cleanup, consistency fixes, and improved sample comments.

Rewrites and expands the Korean translation of the Freezed README for clarity, accuracy, and completeness. Updates sections to match the latest Freezed documentation, improves technical explanations, and enhances formatting and terminology for better readability and developer guidance.
@coderabbitai
Copy link

coderabbitai bot commented Oct 12, 2025

Walkthrough

Korean translation README for Freezed was extensively rewritten to reflect Dart 3 and v3.0.0 migration: examples now use sealed classes and const factories, headings/navigation were restructured, and many code samples and notes were updated for pattern matching, unions, and JSON serialization.

Changes

Cohort / File(s) Summary
Docs — Korean README update
resources/translations/ko_KR/README.md
Major rewrite aligning examples with Dart 3/v3.0.0: convert abstractsealed class declarations, add const to factory constructors, update fromJson/toJson and pattern-matching examples, reorder headings/navigation, and perform broad textual and consistency cleanup across samples and notes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • rrousselGit

Poem

I nibble docs with triple-tap feet,
Sealed dreams and consts so neat.
Patterns hop and unions play,
In Korean fields we shape the way.
Little rabbit inks the day. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly indicates that this PR updates the Korean Freezed README with improved translations, which directly reflects the large-scale localization and migration-focused updates made in the documentation examples. It is concise, specific to the documentation change, and informs reviewers of the main purpose of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cdb847 and 4e0a491.

📒 Files selected for processing (1)
  • resources/translations/ko_KR/README.md (35 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
resources/translations/ko_KR/README.md

128-128: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: freezed (packages/freezed, stable, get)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d89c1a2 and 1cdb847.

📒 Files selected for processing (1)
  • resources/translations/ko_KR/README.md (35 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
resources/translations/ko_KR/README.md

128-128: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


547-547: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: freezed (packages/freezed, stable, get)

Comment on lines 128 to 130
```
flutter pub run build_runner build
dart run build_runner watch -d
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Specify the fenced code block language.

markdownlint flags this block (MD040). Add console to match surrounding examples and keep lint green.

Apply this diff:

-```
+```console
 dart run build_runner watch -d

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 markdownlint-cli2 (0.18.1)</summary>

128-128: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

In resources/translations/ko_KR/README.md around lines 128 to 130, the fenced
code block is missing a language spec which triggers markdownlint MD040; update
the block opening fence from toconsole and keep the same command content
(preserve the line with "dart run build_runner watch -d") so the block matches
surrounding examples and the linter.


</details>

<!-- fingerprinting:phantom:triton:sabertoothed -->

<!-- This is an auto-generated comment by CodeRabbit -->

Comment on lines 547 to 548
**null 고려사항**

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use a proper heading instead of bold text.

MD036 complains because this line imitates a heading with bold text. Promote it to an actual heading (####) to satisfy the linter.

Apply this diff:

-**null 고려사항**
+#### null 고려사항
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
**null 고려사항**
#### null 고려사항
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

547-547: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🤖 Prompt for AI Agents
In resources/translations/ko_KR/README.md around lines 547 to 548, the line
"**null 고려사항**" is formatted as bold text that mimics a heading and triggers
MD036; replace the bold formatting with an actual markdown heading (e.g., prefix
the line with "#### " to make it a level-4 heading) so the linter accepts it and
keep the text unchanged otherwise.

Corrected the capitalization of 'null' in a section heading to 'Null' for consistency in the ko_KR translation README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant