-
-
Notifications
You must be signed in to change notification settings - Fork 286
docs: Update Korean Freezed README with improved translations #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: Update Korean Freezed README with improved translations #1307
Conversation
Rewrites and expands the Korean translation of the Freezed README for clarity, accuracy, and completeness. Updates sections to match the latest Freezed documentation, improves technical explanations, and enhances formatting and terminology for better readability and developer guidance.
WalkthroughKorean translation README for Freezed was extensively rewritten to reflect Dart 3 and v3.0.0 migration: examples now use sealed classes and const factories, headings/navigation were restructured, and many code samples and notes were updated for pattern matching, unions, and JSON serialization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 markdownlint-cli2 (0.18.1)resources/translations/ko_KR/README.md128-128: Fenced code blocks should have a language specified (MD040, fenced-code-language) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
resources/translations/ko_KR/README.md(35 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
resources/translations/ko_KR/README.md
128-128: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
547-547: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: freezed (packages/freezed, stable, get)
| ``` | ||
| flutter pub run build_runner build | ||
| dart run build_runner watch -d | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify the fenced code block language.
markdownlint flags this block (MD040). Add console to match surrounding examples and keep lint green.
Apply this diff:
-```
+```console
dart run build_runner watch -d
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.18.1)</summary>
128-128: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
In resources/translations/ko_KR/README.md around lines 128 to 130, the fenced
code block is missing a language spec which triggers markdownlint MD040; update
the block opening fence from toconsole and keep the same command content
(preserve the line with "dart run build_runner watch -d") so the block matches
surrounding examples and the linter.
</details>
<!-- fingerprinting:phantom:triton:sabertoothed -->
<!-- This is an auto-generated comment by CodeRabbit -->
| **null 고려사항** | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a proper heading instead of bold text.
MD036 complains because this line imitates a heading with bold text. Promote it to an actual heading (####) to satisfy the linter.
Apply this diff:
-**null 고려사항**
+#### null 고려사항📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| **null 고려사항** | |
| #### null 고려사항 |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
547-547: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🤖 Prompt for AI Agents
In resources/translations/ko_KR/README.md around lines 547 to 548, the line
"**null 고려사항**" is formatted as bold text that mimics a heading and triggers
MD036; replace the bold formatting with an actual markdown heading (e.g., prefix
the line with "#### " to make it a level-4 heading) so the linter accepts it and
keep the text unchanged otherwise.
Corrected the capitalization of 'null' in a section heading to 'Null' for consistency in the ko_KR translation README.
Updated the Korean translation to match the latest version of the README.
Thanks!
Summary by CodeRabbit