Skip to content

[document] fix minor issues/typos #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2022
Merged

[document] fix minor issues/typos #1109

merged 2 commits into from
Jan 22, 2022

Conversation

toshi-kuji
Copy link
Contributor

@toshi-kuji toshi-kuji commented Jan 22, 2022 •
edited
Loading

This PR will fix minor issues/typos I've found in the En document during the translation.

  1. To be more clear about value coming from a parameter name:

the value exposed is value
the value exposed is value

  1. A typo:

unsure
ensure

  1. Aligning with other parts of the before/after comparison, add:

Before:

  1. Seems the pub get command is no longer available:

pub get
dart pub get

  1. Aligning with the official abbreviation:

Vscode
VS Code

  1. HookConsumerWidget comes from hooks_riverpod:

flutter_hooks
hooks_riverpod

dart
sh

FYI: These are already fixed in the Ja docs.

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #1109 (9f89944) into master (b9a9ef4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1109   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          32       32           
  Lines        1631     1631           
=======================================
  Hits         1596     1596           
  Misses         35       35

@rcjuancarlosuwu
Copy link
Contributor

I have also noticed them. These observations will be fixed in the Spanish translation too.

@rrousselGit
Copy link
Owner

Thanks!

@rrousselGit rrousselGit merged commit f920281 into rrousselGit:master Jan 22, 2022
@toshi-kuji toshi-kuji deleted the fix-minor-issues branch January 23, 2022 04:34
abdulmominsakib added a commit to abdulmominsakib/river_pod that referenced this pull request Jan 28, 2022
@abdulmominsakib
Squashed commit of the following:
d8b6876 
commit 7f182ca
Author: Remi Rousselet <[email protected]>
Date:   Sun Jan 23 00:41:44 2022 +0100

    changelog

commit 967070c
Author: Remi Rousselet <[email protected]>
Date:   Sun Jan 23 00:40:51 2022 +0100

    Fixed a cast error when overriding a provider with a more specific provider type

    fixes rrousselGit#1100

commit 176d10d
Author: Aspiiire <[email protected]>
Date:   Sat Jan 22 23:19:25 2022 +0100

    Adding .update() to docs (rrousselGit#1061)

    Co-authored-by: Remi Rousselet <[email protected]>

commit f920281
Author: Toshi Kuji <[email protected]>
Date:   Sun Jan 23 01:17:20 2022 +0900

    fix minor issues in docs (rrousselGit#1109)

commit b9a9ef4
Author: Remi Rousselet <[email protected]>
Date:   Sat Jan 22 14:28:58 2022 +0100

    Extract StateProvider snippets

commit 51b699a
Author: Remi Rousselet <[email protected]>
Date:   Fri Jan 21 12:28:25 2022 +0100

    fix warnings

commit 8a5efbe
Author: Remi Rousselet <[email protected]>
Date:   Fri Jan 21 12:28:12 2022 +0100

    cross reference provider docs

commit d8a6703
Author: Remi Rousselet <[email protected]>
Date:   Fri Jan 21 12:17:13 2022 +0100

    Add Dartpad embed to StateProvider

commit 8805d85
Author: Remi Rousselet <[email protected]>
Date:   Fri Jan 21 12:05:33 2022 +0100

    add dartpad_metadata.yaml

commit 8b52750
Author: Remi Rousselet <[email protected]>
Date:   Fri Jan 21 12:02:03 2022 +0100

    docs: add StateProvider docs

commit 7b2a68e
Author: Juan Carlos Ramón Condezo <[email protected]>
Date:   Fri Jan 21 04:48:27 2022 -0500

    Add Spanish website translation (rrousselGit#1106)

commit 8359942
Author: Willy Hong <[email protected]>
Date:   Fri Jan 21 02:30:34 2022 +0800

    Fix typo in Japanese docs (rrousselGit#1105)

commit 2a0e36b
Author: Toshi Kuji <[email protected]>
Date:   Fri Jan 21 02:07:29 2022 +0900

    add Japanese docs for website (rrousselGit#1103)

commit 610ebe0
Author: Remi Rousselet <[email protected]>
Date:   Tue Jan 18 13:17:26 2022 +0100

    FutureProvider doc (rrousselGit#1097)

commit ef5eb5b
Author: Remi Rousselet <[email protected]>
Date:   Sun Jan 16 17:26:24 2022 +0100

    cross reference providers x2

commit 699ff04
Author: Remi Rousselet <[email protected]>
Date:   Sun Jan 16 17:26:01 2022 +0100

    cross reference provider docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toshi-kuji @rcjuancarlosuwu @rrousselGit