This repository was archived by the owner on Oct 23, 2022. It is now read-only.
move the Repo from Ipfs to IpfsFuture#264
Closed
ljedrz wants to merge 9 commits intors-ipfs:masterfrom
Closed
Conversation
ljedrz
force-pushed
the
current
branch
3 times, most recently
from
1927c5b to
0efe8f6
Compare
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
ljedrz
commented
Jul 28, 2020
| if let RequestKind::GetBlock(cid) = req { | ||
| Ok(IpfsEvent::CancelBlock(cid)) | ||
| } else { | ||
| Err("logic error: RepoEvent can only be created from a Request::GetBlock") |
Member
Author
There was a problem hiding this comment.
Suggested change
| Err("logic error: RepoEvent can only be created from a Request::GetBlock") | |
| Err("logic error: IpfsEvent can only be created from a Request::GetBlock") |
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jul 30, 2020
271: Adjust subscription locking r=ljedrz a=koivunej Fixes the number of critical sections in SubscriptionFuture from 2 to 1, helping out with the hangs in exchange_block which have been recorded in #134. Also backports the `related_subs` cleanup from #264. Co-authored-by: Joonas Koivunen <joonas@equilibrium.co>
Member
Author
|
Closing this one for now, as it's a spicy change set; we might go back to this approach in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell from the comments, this has been the plan / target design for a while now. These changes carry a few important improvements:
Ipfsis no longer generic 🎉 (a huge advantage for IPFS-as-a-library)IpfsandIpfsFutureviaRepoEventsIpfsmethods become uniform in the way they workIpfsto be within anArc(though it might be preferable for future-proofing)This is still a work in progress, as:
Ipfsmethods remain to be convertedRepoEventfunctionalities need to be re-introducedwantlist_and_cancellationtest needs to be fixedThe conformance tests (excluding the aforementioned missing bits) agree with these changes.