Skip to content

clean up connections in reverse order #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2015

Conversation

javornikolov
Copy link
Collaborator

Perform the connection cleanup and disposal in an order reverse of their initialization.

This is to resolve issues like setup/disposal of resources shared by multiple connections - e.g. profiler tables used by coverage when connections are to the same database schema.

This is an attempt to resolve #20

Perform the connection cleanup and disposal in an order reverse of their
initialization.

This is to resolve issues like setup/disposal of
resources shared by multiple connections - e.g. profiler tables used by
coverage when connections are to the same database schema.
@jgebal
Copy link
Contributor

jgebal commented Jul 25, 2015

Amazingly, this solves the issue 👍

@jgebal
Copy link
Contributor

jgebal commented Jul 25, 2015

@javornikolov the #20 can be closed as resolved and PR #22 merged.
Out of topic.
I'm using ruby-plsql-spec to run cucumber tests too with shared config for both RSpec and Cucumber.
I was wondering on one of two options:

  • contribute to ruby-plsql-spec and refacto it to make it Cukes ready.
  • create a separate project.
    I'd opt for first solution, as it reuses many of existing code.

@javornikolov
Copy link
Collaborator Author

Amazingly, this solves the issue 👍

Coll. I'm merging this PR... Thanks for the feedback and for reporting the issue at first place!

I'm using ruby-plsql-spec to run cucumber tests too with shared config for both RSpec and Cucumber.
I was wondering on one of two options:

  • contribute to ruby-plsql-spec and refactor it to make it Cukes ready.
  • create a separate project.

I'd opt for first solution, as it reuses many of existing code.

Sounds nice. OK, let's try with 1st option and see where it will lead us.

javornikolov added a commit that referenced this pull request Jul 25, 2015
@javornikolov javornikolov merged commit bad4d3e into master Jul 25, 2015
@javornikolov javornikolov deleted the cleanup-connections-in-reverse-order branch July 25, 2015 15:20
@javornikolov javornikolov mentioned this pull request May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coverage report is crashing when running with several connections
2 participants