Skip to content

Bump RuboCop version to 0.81.0 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

yahonda
Copy link
Collaborator

@yahonda yahonda commented Jul 14, 2020

This pull request bumps RuboCop version to 0.81.0.

  • Error if RuboCop 0.82.0 or higher
% bundle exec rubocop
Error: RuboCop found unsupported Ruby version 2.3 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.3-compatible analysis was dropped after version 0.81.
Supported versions: 2.4, 2.5, 2.6, 2.7, 2.8

Note: Will consider to drop older Ruby versions at ruby-plsql itself.

  • Rename Layout/IndentFirstArgument to Layout/FirstArgumentIndentation
    and Layout/TrailingBlankLines to Layout/TrailingEmptyLines using mry
% gem install mry
mry --target=0.81.0 .rubocop.yml
  • Remove Style/BracesAroundHashParameters cop manually
% bundle exec rubocop
Error: RuboCop found unsupported Ruby version 2.3 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.3-compatible analysis was dropped after version 0.81.
Error: The `Style/BracesAroundHashParameters` cop has been removed.
(obsolete configuration found in .rubocop.yml, please update it)

* Error if RuboCop 0.82.0 or higher
```
% bundle exec rubocop
Error: RuboCop found unsupported Ruby version 2.3 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.3-compatible analysis was dropped after version 0.81.
Supported versions: 2.4, 2.5, 2.6, 2.7, 2.8
```

Note: Will consider to drop older Ruby versions at ruby-plsql itself.

* Rename `Layout/IndentFirstArgument` to `Layout/FirstArgumentIndentation`
and `Layout/TrailingBlankLines` to `Layout/TrailingEmptyLines` using mry

```
% gem install mry
mry --target=0.81.0 .rubocop.yml
```

* Remove `Style/BracesAroundHashParameters` cop manually

```
% bundle exec rubocop
Error: RuboCop found unsupported Ruby version 2.3 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.3-compatible analysis was dropped after version 0.81.
Error: The `Style/BracesAroundHashParameters` cop has been removed.
(obsolete configuration found in .rubocop.yml, please update it)
```
@yahonda yahonda merged commit c025448 into rsim:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant