Skip to content

Improve clarity on logic to handle block header compression #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
italo-sampaio wants to merge 1 commit into
base: fmacleal/superevent-blockheader-extension
Choose a base branch
from
+13 −1

Improve clarity on logic to handle block header compression

ecbe93b
Select commit
Loading
Failed to load commit list.
Draft

Improve clarity on logic to handle block header compression #3411

Improve clarity on logic to handle block header compression
ecbe93b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 10, 2025 in 3m 16s

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 120 in rskj-core/src/main/java/org/ethereum/core/BlockFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The Cyclomatic Complexity of this method "decodeHeader" is 15 which is greater than 10 authorized. 

See more on https://sonarcloud.io/project/issues?id=rskj&issues=AZsIg5y9hHvxs6JXP2MA&open=AZsIg5y9hHvxs6JXP2MA&pullRequest=3411

Check failure on line 120 in rskj-core/src/main/java/org/ethereum/core/BlockFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=rskj&issues=AZsIg5y9hHvxs6JXP2L_&open=AZsIg5y9hHvxs6JXP2L_&pullRequest=3411
View more details on SonarQubeCloud