Refactor logic to add base event data into new block headers post RSKIP535 activation #3417
+239
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
julia-zack
reviewed
Dec 11, 2025
| blockHeaderBuilder.setReceiptTrieRoot(receiptTrieRoot); | ||
|
|
||
| byte[] extensionData = rlpHeader.get(6).getRLPData(); | ||
| blockHeaderBuilder.setLogsBloom(extensionData); |
Contributor
There was a problem hiding this comment.
logsBloom should be renamed to extensionData as in other places
julia-zack
reviewed
Dec 11, 2025
| BlockHeaderBuilder blockHeaderBuilder = new BlockHeaderBuilder(activationConfig); | ||
| fillFirstFields(blockHeaderBuilder, rlpHeader); | ||
|
|
||
| int r = 16; |
Contributor
There was a problem hiding this comment.
Suggested change
| int r = 16; | |
| int r = INITIAL_RLP_HEADER_SIZE; |
more accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: