Migration-transaction-multiple-utxos integration #3423
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gFederationOptional
…utputs how the retiring fed is obtained and the exception thrown
… response codes are shorter
… empty, having two asserts is enough
…ptional Changed getRetiringFederation so it returns an optional
…turnsOptional changed getRetiringFederationWallet() so it returns an Optional
…factor changed getActiveFederationBtcUTXOs to replace the switch with an if
…t depending on the federation age is before/now/after migration age, finally moved some logs to FederationSupport
…Support, added test and performed some renamings
…eting the parameter and therefore, deleting any reference to an activeFederation in processFundsMigration, same with isInMigrationAge. Besides, changed the switch getActiveFederation
…ted the booleans that logs if is past migraiton age or in migration age, besides I added the fed address in the log
Move isInMigrationAge and isPastMigrationAge to FederationSupport
…made in buildWithConfiguration. So, from now on, createMigrationTransaction returns a BuildResult. Besides, BuildResult is static because it improves memory management, and it doesn't need to access any instance variable of its outer class
…urns-BuildResult createMigrationTransaction returns a BuildResult
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ReleaseTransactionBuilder.BuildResult result = txBuilder.buildMigrationTransaction(expectedMigrationValue, destinationAddress); | ||
|
|
||
| switch (result.getResponseCode()) { | ||
| switch (result.responseCode()) { |
Check warning
Code scanning / CodeQL
Missing enum case in switch Warning
Copilot Autofix
AI 1 day ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
…of the FEDERATION_NON_EXISTENTs
…-optional turn getRetiringFederationThreshold to return an optional
…of the FEDERATION_NON_EXISTENTs
…onal turn getRetiringFederationSize to return an optional
…hBasedOnActivation and reuse the method in getFederationCreationTime
…ime-optional turn getRetiringFederationCreationTime to return an optional
…lockNumber-optional Turn retiring federation creation block number optional
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: