#49 provides composite metadata implementation #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
added
the
enhancement
OlegDokuka
force-pushed
the
feature/composite-metadata
branch
2 times, most recently
from
7a2a881 to
aee21ed
Compare
OlegDokuka
force-pushed
the
feature/composite-metadata
branch
from
aee21ed to
58e6677
Compare
hypothete
reviewed
Oct 8, 2019
| function fromArrayBuffer(array: any, byteOffset?: number, length?: number) { | ||
| let buf; | ||
| function fromArrayBuffer(array: any, byteOffset?: number, length?: number): Buffer { | ||
| let buf: Buffer; |
There was a problem hiding this comment.
This typing is throwing a bunch of Flow errors when I run the tests. Otherwise, no concerns.
There was a problem hiding this comment.
sure. Actually I'm still not able to configure my flow correctly. So it was just my "Typescript" and some blind kitty steps over the whole codebase 😿
hypothete
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an implementation of Composite Metadata mostly ported from Java Implementation