experiment! Try using tagged logging for real

Author: pirj

lib/rspec/rails/adapters.rb

@@ -185,10 +185,31 @@ def assertion_delegator
     # @private
     module TaggedLoggingAdapter
       require 'active_support/testing/tagged_logging'
-      include ActiveSupport::Testing::TaggedLogging
 
-      # Just a stub as TaggedLogging is calling `name`
-      def name
+      def before_setup
+        @__wrapped_tagged_logger = WrappedTaggedLogging.new(@__inspect_output)
+        @__wrapped_tagged_logger.before_setup
+      end
+
+      def tagged_logger
+        @__wrapped_tagged_logger.tagged_logger
+      end
+
+      class WrappedTaggedLogging
+        # TaggedLogging attempts calling `super`
+        include Module.new { def before_setup; end }
+        include ActiveSupport::Testing::TaggedLogging
+
+        attr_reader :name
+
+        def initialize(name)
+          @name = name
+        end
+
+        # It is private in the TaggedLogging module
+        def tagged_logger
+          super
+        end
       end
     end
   end

snippets/include_activesupport_testing_tagged_logger.rb

@@ -29,6 +29,7 @@
   end
 
   gem "rspec-rails", path: "../"
+  gem 'pry-byebug'
 end
 
 # Run specs at exit
@@ -54,6 +55,14 @@ class TestError < StandardError; end
   include ::ActiveJob::TestHelper
 
   describe 'error raised in perform_enqueued_jobs with block' do
+    class StringIncompatible
+      def to_s
+        raise 'to_s was called on `name`'
+      end
+    end
+
+    let(:name) { StringIncompatible.new }
+
     it 'raises the explicitly thrown error' do
       allow_any_instance_of(TestJob).to receive(:perform).and_raise(TestError)
 
@@ -64,8 +73,13 @@ class TestError < StandardError; end
                          TestError
                        end
 
-      expect { perform_enqueued_jobs { TestJob.perform_later } }
-        .to raise_error(expected_error)
+      # expect {
+        # Necessary to make sure the tagged logging hook runs
+        Rails.logger = Logger.new($stderr)
+
+        expect { perform_enqueued_jobs { TestJob.perform_later } }
+          .to raise_error(expected_error)
+      # }.to output(/\[ActiveJob\] \[TestJob\] \[[^\]]+\] Error performing TestJob/).to_stderr
     end
   end
 end