Skip to content

generator for system spec #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

generator for system spec #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8e62dc
added generator for system spec
andrzejsliwa Dec 28, 2017
40f51a4
fixed spec for --no-system-specs
andrzejsliwa Dec 28, 2017
232a52f
refactored to ensure that both usecases are using same path
andrzejsliwa Dec 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/generators/rspec/system/system_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
require 'generators/rspec'

module Rspec
module Generators
# @private
class SystemGenerator < Base
class_option :system_specs, :type => :boolean, :default => true, :desc => "Generate system specs"

def generate_feature_spec
Copy link

@joshRpowell joshRpowell Jan 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be generate_system_spec?

return unless options[:system_specs]
Copy link

@joshRpowell joshRpowell Jan 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrzejsliwa perhaps you'll have something more elegant in mind, but inserting something like this is a start:

begin
  raise ArgumentError.new('System Tests are available for Rails >= 5.1') if Rails::VERSION::STRING < '5.1'
rescue ArgumentError => e
  puts e.message
end


template template_name, File.join('spec/system', class_path, filename)
end

def template_name
'system_spec.rb'
end

def filename
"#{table_name}_spec.rb"
end
end
end
end
9 changes: 9 additions & 0 deletions lib/generators/rspec/system/templates/system_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
require 'rails_helper'

RSpec.describe "<%= class_name.pluralize %>", <%= type_metatag(:system) %> do
before do
driven_by(:rack_test)
end

pending "add some scenarios (or delete) #{__FILE__}"
end
38 changes: 38 additions & 0 deletions spec/generators/rspec/system/system_generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Generators are not automatically loaded by rails
require 'generators/rspec/system/system_generator'
require 'support/generators'

RSpec.describe Rspec::Generators::SystemGenerator, :type => :generator do
setup_default_destination

describe 'system specs' do
subject(:system_spec) { file('spec/system/posts_spec.rb') }
describe 'are generated independently from the command line' do
before do
run_generator %w(posts)
end
describe 'the spec' do
it "exists" do
expect(system_spec).to exist
end
it "contains 'rails_helper'" do
expect(system_spec).to contain(/require 'rails_helper'/)
end
it "contains the system" do
expect(system_spec).to contain(/^RSpec.describe \"Posts\", #{type_metatag(:system)}/)
end
end
end

describe "are not generated" do
before do
run_generator %w(posts --no-system-specs)
end
describe "the spec" do
it "does not exist" do
expect(system_spec).to_not exist
end
end
end
end
end