generator system spec: closing 1933 #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoittgt
commented
Jan 30, 2019
|
|
||
| def generate_system_spec | ||
| return unless options[:system_specs] | ||
| raise "System Tests are available for Rails >= 5.1" if ::Rails::VERSION::STRING < '5.1' |
There was a problem hiding this comment.
Is it what we want? 🤔
I look at other parts of RSpec code and didn't see that kind of behavior implemented.
There was a problem hiding this comment.
The generator shouldn't be available on old rails...
There was a problem hiding this comment.
So we should have a higher condition if not on > Rails 5.1?
There was a problem hiding this comment.
I don't think we should even define it we can't run it.
benoittgt
commented
Jan 30, 2019
|
|
||
| describe "system specs" do | ||
| subject(:system_spec) { file("spec/system/posts_spec.rb") } | ||
| if ::Rails::VERSION::STRING < '5.1' |
There was a problem hiding this comment.
Do we want this as a gate or do we want to tag the example to don't be run under Rails 5.1?
benoittgt
changed the title
benoittgt
force-pushed
the
andrzejsliwa/generator_system_spec
branch
from
d01c40f to
5a8928d
Compare
benoittgt
force-pushed
the
andrzejsliwa/generator_system_spec
branch
from
5a8928d to
79316d2
Compare
JonRowe
approved these changes
Jan 31, 2019
|
Thanks @JonRowe for the review |
benoittgt
added a commit
to benoittgt/rspec-rails
that referenced
this pull request
Feb 22, 2019
Merged via rspec#2075
benoittgt
added a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
Merged via rspec#2075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to close the #1933
CI will probably fail this is a WIP PR but open for review.
For exemple why do I get:
expected RuntimeError with "System Tests are available for Rails >= 5.1", got #<RuntimeError: System Tests are available for Rails >= 5.1> with backtrace: