-
-
Notifications
You must be signed in to change notification settings - Fork 1k
CI: Add --add-opens in order to support JDK11 #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00b1d29
to
0b53a5d
Compare
(Oh, that failed miserably. Somehow, the formatting does not do the right thing.) |
@JonRowe Do you know a way to use multi-line & still have it understand the settings? |
The quotes worked to set the env, why that didn't fix Jruby 🤷♂ |
da7d266
to
65ec96c
Compare
OK, thanks! I squashed the PR into 1 commit, and that takes me to "Selenium has a tough time loading". No warnings about We are in the place I wanted to get to. |
Hello @olleolleolle I still have breaking build
|
7d9f8b5
to
e6becab
Compare
Can you remind me what this is fixing @olleolleolle? |
Yes, this makes this JRuby build and run on current JDKs.
If we have older JDKs active, (JDK8, only, at the moment), we can forgo the |
This PR adds a few ENV variables to the JAVA_OPTS, in order to make
openjdk11oraclejdk11 not output warnings (and illegal reflective access).(I think I will run this a few times.)
See #2147
oraclejdk11
Article about thejdk
setting--add-opens